The Peptide CommonsEst. May 2024
Independent. We sell nothing and are affiliated with no manufacturer or pharmacy. Every moderation action is logged in public
Documentation · Doc review · continued

Promotion criteria, and the one that stops most nominations posts 31–60

This is a continuation of a long topic, addressed by post number rather than by page. Start at post 1.

MN
m.ndiayeTL24 Aug 2024#31

Post #30 is right about the mechanism and I think understates the practical bit.

Agreed on promotion criteria, with one qualification that I think matters. The reasoning holds for the case as described. Change the starting assumption and it does not, and the starting assumption is the part nobody states.

1 like 2y
LC
l.chevalierTL3Regular6 Aug 2024#32

Coming back to post #28, because the follow-up matters more than the original answer.

A methods point on promotion criteria rather than a substantive one: if the comparison is not like for like, the difference you are measuring is the difference in method.

6 likes 2y
PB
p.boatengTL27 Aug 2024#33
CD
cohort_driftTL3Regular9 Aug 2024#34
Ziegler, post #4: The version of promotion criteria that circulates here is a simplification of a simplification. It is not wrong, but it has lost the conditions under which it holds, and those conditions are where the interesting cases live. Go to post

The most useful review comment names a sentence and says what is wrong with it. General approval and general concern are both hard to act on.

I have kept the units in throughout, for the obvious reason.

0 likes in reply to #4 2y
TI
t.ibarraTL210 Aug 2024#35

Reviewing your own nomination is fine and is not sufficient. Somebody else has to read it for the process to mean anything.

Not disagreeing with anyone above, just adding the bit I keep having to look up.

3 likes 2y
I
IsaksenTL3Regular11 Aug 2024#36

This is the first time the answer has come with its own limits attached. Appreciated.

10 likes 2y
TB
t.batistaTL213 Aug 2024#37

Two people in this thread mean different things by promotion criteria and are disagreeing about the definition while believing they are disagreeing about the facts. Worth pausing to define it.

30 likes 23mo
BP
bench_peakTL3Regular14 Aug 2024#38
titration_diary, post #1: Promotion criteria, and the one that stops most nominations — setting out what I have, and where I think it stops being reliable. Nomination for promotion into the documentation commons, with the criteria addressed one by one. The question recurs, the answer in the topic is correct and sourced, and I am willing to be named as maintainer… Go to post

A promotion that is declined should leave the topic linked from wherever the question recurs, so the work is not lost.

0 likes in reply to #1 23mo
SF
s.ferreiraTL216 Aug 2024#39

Check the links. Promotion frequently breaks a cross-reference because the source topic now points at the document rather than the reverse.

6 likes 23mo
OC
o.cousineauTL3Regular17 Aug 2024#40
ppm_error, post #19: I will take the caveat as seriously as the claim, which is the point of putting it there. Go to post

Where the review finds the content is right but the framing overstates it, that is the most valuable catch available at this stage.

15 likes in reply to #19 23mo
FD
f.demirTL2Regular18 Aug 2024#41

The documentation on promotion criteria is better than this thread and I say that as someone who has posted in the thread.

0 likes 23mo
SB
s.balogunTL220 Aug 2024#42
z.vogel, post #7: The most useful review comment names a sentence and says what is wrong with it. General approval and general concern are both hard to act on. I have seen it go both ways, which is why I hedge. Go to post

The arithmetic in post #41 is right; the assumption feeding it is the part to check.

The four criteria are that the question recurs, that the content is correct and sourced or labelled as community practice, that somebody will be named as maintainer with a review date, and that no unresolved substantive objection stands.

This is the sort of thing the wiki should carry and currently does not.

25 likes in reply to #7 23mo
RM
r.mcalisterTL3Regular21 Aug 2024#43

Post #41 put the caveat in the right place and I want to underline it.

Adding what did not work for me on promotion criteria, since the failures never get written up and they are half the useful information.

11 likes 23mo
AI
a.iyerTL223 Aug 2024#44

Sensible. I would want the same detail before I acted on it either.

3 likes 23mo
DT
dexa_twice_yearlyTL3Regular24 Aug 2024#45

Second maintainers matter. A single maintainer is a single point of failure and every document here that went stale had one.

0 likes 23mo
RN
r.nakamuraTL225 Aug 2024#46
g.verhoeven, post #3: I have no financial interest in anything named in this thread and I want to say so before I comment on promotion criteria, because it is the sort of subject where it matters. Go to post

The claim about promotion criteria upthread is stronger than its source supports. I have read the source. The source says "associated with" and the post says "causes".

18 likes in reply to #3 23mo
GP
g.pemberton_ukTL3Regional · UK27 Aug 2024#47

Where I part company with post #45, and it is a narrow parting.

Promotion criteria: I would want to see the raw numbers rather than the summary before agreeing. Summaries lose exactly the information that would settle this.

7 likes 23mo
RS
r.szaboTL228 Aug 2024 · edited#48

Post #45 is the version of this I will quote in future. One addition.

Point three stops most nominations. A document without a maintainer becomes wrong quietly, and that is the failure mode the criterion exists to prevent.

I would want to see it done twice before believing it once.

1 like 23mo
CR
crossover_reviewTL329 Aug 2024#49
NB
n.boatengTL231 Aug 2024#50

The reason promotion criteria is hard to answer is that the obvious measurement and the relevant quantity are not the same thing, and substituting one for the other is silent.

0 likes 23mo
B
BBramleyTL3Regular1 Sep 2024#51
m.duarte, post #26: Post #23 answers the question as asked. The question underneath it is different. Adding a null result on promotion criteria. I looked, carefully, and found nothing, and null results deserve posting precisely because they never are. Go to post

The arithmetic in post #48 is right; the assumption feeding it is the part to check.

Something worth flagging about promotion criteria: the strongest-sounding claims in this thread are the ones with no source attached, which is the usual pattern and not a coincidence.

0 likes in reply to #26 23mo
KO
k.okaforTL22 Sep 2024#52

Point three stops most nominations. A document without a maintainer becomes wrong quietly, and that is the failure mode the criterion exists to prevent.

4 likes 23mo
L
LeitermanTL3Regular4 Sep 2024#53

The bit of promotion criteria that nobody enjoys is that the answer changes depending on what you are trying to decide with it. Say what the decision is and the thread will converge.

13 likes 23mo
GE
g.ekstromTL25 Sep 2024#54

Reviewing your own nomination is fine and is not sufficient. Somebody else has to read it for the process to mean anything.

The confident version of this sentence would be wrong, so here is the hedged one.

26 likes 23mo
RM
r.marsdenTL3Regular6 Sep 2024#55
cohort_drift, post #34: The most useful review comment names a sentence and says what is wrong with it. General approval and general concern are both hard to act on. I have kept the units in throughout, for the obvious reason. Go to post

That is a fair summary of where the discussion has got to.

0 likes in reply to #34 23mo
NS
n.serranoTL28 Sep 2024#56
g.pemberton_uk, post #47: Where I part company with post #45, and it is a narrow parting. Promotion criteria: I would want to see the raw numbers rather than the summary before agreeing. Summaries lose exactly the information that would settle this. Go to post

Second-hand on promotion criteria, so weight it accordingly — someone whose method I trust told me this and I have not verified it myself.

2 likes in reply to #47 23mo
GV
g.valckenaereTL3Regular9 Sep 2024 · edited#57

Where the review finds the content is right but the framing overstates it, that is the most valuable catch available at this stage.

I would put the burden of proof on the interesting explanation, not the dull one.

8 likes 23mo
FF
f.fontaineTL210 Sep 2024#58

I had written a reply contradicting post #54 and deleted it. Here is what survived.

If you are new and reading this thread for the answer to promotion criteria: the answer is conditional, the conditions are in the third reply, and the rest of the thread is worth skipping.

19 likes 23mo
DN
desiccant_notesTL2Member11 Sep 2024#59

The most useful review comment names a sentence and says what is wrong with it. General approval and general concern are both hard to act on.

4 likes 23mo
SR
s.roosTL213 Sep 2024#60

I read post #58 twice before replying, because I had assumed the opposite.

The arithmetic on promotion criteria is the easy part and it is where the errors are, which is an uncomfortable combination. Show your working and someone will catch it.

12 likes 22mo